-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix Error using ctrl-c
in dev mode
#727
Conversation
🦋 Changeset detectedLatest commit: 4b94bf5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2060692348/npm-package-wrangler-727 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/727/npm-package-wrangler-727 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2060692348/npm-package-wrangler-727 dev path/to/script.js |
…t cleaning up the SIGINT didnt allow for graceful shutdown for subsequent startups of proxyServer
01974b0
to
4b94bf5
Compare
ctrl-c
in dev modectrl-c
in dev mode
Good catch! I tested this and couldn't reproduce the error anymore. There's a separate issue where we need to hit ctrl-c twice to actually quit the process, but we should file a different issue and track that separately. Happy to stamp this PR if you open it for review. |
Thanks! Pete found a deeper cause which solves this and the needing to hit |
The
proxyServer
was conducting async behavior inuseEffect
without cleaning up, the SIGINT didn't allow for graceful shutdown for subsequent startups ofproxyServer
.resolve #375