bugfix: proxyServer was conducting async behavior in useEffect withou…

…t cleaning up the SIGINT didnt allow for graceful shutdown for subsequent startups of proxyServer
cloudflare · Mar 29, 2022 · 4b94bf5 · 4b94bf5
1 parent c4e5dc3
commit 4b94bf5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/.changeset/flat-ladybugs-care.md b/.changeset/flat-ladybugs-care.md
@@ -0,0 +1,7 @@
+---
+"wrangler": patch
+---
+
+bugfix: The proxyServer was conducting async behavior in useEffect without cleaning up the SIGINT didn't allow for graceful shutdown for subsequent startups of proxyServer.
+
+fixes #375
diff --git a/packages/wrangler/src/proxy.ts b/packages/wrangler/src/proxy.ts
@@ -96,6 +96,12 @@ export function usePreviewServer({
           await reportError(err);
         });
     }
+    return () => {
+      if (proxyServer !== undefined) {
+        proxyServer.close();
+        setProxyServer(undefined);
+      }
+    };
   }, [proxyServer, localProtocol]);
 
   /**