-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only show fetch warning if on old compatibility_date #7038
Conversation
🦋 Changeset detectedLatest commit: d7f86a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-wrangler-7038 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7038/npm-package-wrangler-7038 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-wrangler-7038 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-create-cloudflare-7038 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-kv-asset-handler-7038 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-miniflare-7038 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-pages-shared-7038 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-vitest-pool-workers-7038 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-workers-editor-shared-7038 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-workers-shared-7038 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-workflows-shared-7038 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 files for such a small change 😢
7632bf5
to
80d8404
Compare
@petebacondarwin @penalosa not just hiding the warning, fetching with custom HTTPS port doesn't work too, looks like the port is wiped somewhere |
@ceddybi - good point. It seems that on production this now works correctly if the compat date is new (>2024-09-01) or the compat flag is on (allow_custom_ports). But my local testing seems to show workerd crashing in Miniflare. I need to dig in why that is the case. Notwithstanding that, this PR is still valid, since in production the warning is no longer needed when the compat date/flag is setup correctly. |
e6e9d16
to
b09dc38
Compare
b09dc38
to
eb0ce6f
Compare
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
eb0ce6f
to
d7f86a1
Compare
Now that we have the
allow_custom_ports
compatibility flag, we only need to show the fetch warnings when that flag is not enabled.Fixes #6950
Fixes cloudflare/workerd#2955
Author has addressed the following