Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show fetch warning if on old compatibility_date #7038

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Oct 21, 2024

Now that we have the allow_custom_ports compatibility flag, we only need to show the fetch warnings when that flag is not enabled.

Fixes #6950

Fixes cloudflare/workerd#2955

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: d7f86a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-wrangler-7038

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7038/npm-package-wrangler-7038

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-wrangler-7038 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-create-cloudflare-7038 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-kv-asset-handler-7038
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-miniflare-7038
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-pages-shared-7038
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-vitest-pool-workers-7038
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-workers-editor-shared-7038
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-workers-shared-7038
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11795973949/npm-package-cloudflare-workflows-shared-7038

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 files for such a small change 😢

fixtures/worker-app/src/index.js Outdated Show resolved Hide resolved
@petebacondarwin petebacondarwin force-pushed the pdb/dont-check-fetch-if-unnecessary branch 2 times, most recently from 7632bf5 to 80d8404 Compare October 21, 2024 15:02
@ceddybi
Copy link

ceddybi commented Oct 21, 2024

@petebacondarwin @penalosa not just hiding the warning, fetching with custom HTTPS port doesn't work too, looks like the port is wiped somewhere

@petebacondarwin
Copy link
Contributor Author

@ceddybi - good point. It seems that on production this now works correctly if the compat date is new (>2024-09-01) or the compat flag is on (allow_custom_ports). But my local testing seems to show workerd crashing in Miniflare. I need to dig in why that is the case. Notwithstanding that, this PR is still valid, since in production the warning is no longer needed when the compat date/flag is setup correctly.

@petebacondarwin petebacondarwin force-pushed the pdb/dont-check-fetch-if-unnecessary branch from e6e9d16 to b09dc38 Compare November 7, 2024 20:56
@petebacondarwin petebacondarwin added the skip-pr-description-validation Skip validation of the required PR description format label Nov 7, 2024
@petebacondarwin petebacondarwin marked this pull request as ready for review November 7, 2024 21:00
@petebacondarwin petebacondarwin requested review from a team as code owners November 7, 2024 21:00
@CarmenPopoviciu CarmenPopoviciu added the e2e Run e2e tests on a PR label Nov 8, 2024
@CarmenPopoviciu CarmenPopoviciu force-pushed the pdb/dont-check-fetch-if-unnecessary branch from b09dc38 to eb0ce6f Compare November 8, 2024 14:26
@CarmenPopoviciu CarmenPopoviciu added e2e Run e2e tests on a PR and removed e2e Run e2e tests on a PR labels Nov 8, 2024
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled.

Fixes cloudflare/workerd#2955
@andyjessop andyjessop force-pushed the pdb/dont-check-fetch-if-unnecessary branch from eb0ce6f to d7f86a1 Compare November 12, 2024 11:05
@andyjessop andyjessop merged commit e2e6912 into main Nov 18, 2024
21 of 22 checks passed
@andyjessop andyjessop deleted the pdb/dont-check-fetch-if-unnecessary branch November 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
5 participants