-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug Report — allow_custom_ports is not working #2955
🐛 Bug Report — allow_custom_ports is not working #2955
Comments
Is the problem you’re having just the error message or is the functionality not working as intended in a deployed worker? |
@danlapid i haven't deployed it yet, i'm trying in dev using |
Seems like we might’ve missed that then, it should work in local dev without the —remote flag and in a deployed worker |
@danlapid it's actually working, i logged the request the real issue is i'm getting 526 (invalid certificate), my app wasn't checking for this status code, that's why it was stuck but i had set |
Looks like without |
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
In |
What happens in prod, do we need to provide the certs too? or prod can ignore 526's Woulda been nice if |
OK so I did some digging and I think I have an understanding of all this now. In production: In wrangler dev: Outbound fetches to HTTPS ports that are hosted on local servers using self-signed certificates will fail because workerd will fail to make the TLS connection giving errors about the certificates not being trusted. The solution to this is to tell workerd about your local Certificate Authority certificates, which you use to sign the certificates that the local HTTPS server is using. You do this by setting See https://gist.github.com/petebacondarwin/804f390138570eb99e34c974c0c68585 |
@petebacondarwin what about in production when you make outbound fetches to custom HTTPS ports that are hosted on remote servers using self-signed certificates? |
I don't believe we have any way to support self-signed certificates in production. |
It is quite easy, and free, to set up domains with Cloudflare to have fully trusted certificates, so I would recommend doing that even for test servers if they are exposed on the public Internet. |
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955
* fix: only show fetch warning if on old compatibility_date Now that we have the `allow_custom_ports` compatibility flag, we only need to show the fetch warnings when that flag is not enabled. Fixes cloudflare/workerd#2955 * fix: typo
According to allow-specifying-a-custom-port-when-making-a-subrequest-with-the-fetch-api
it says that setting the flag
allow_custom_ports
or a compatibility date greater than 2024-09-02, should allow fetch to work with custom ports for HTTPS, however settings this has no effect, you still get the warning and the api errors outknown issue with fetch() requests to custom HTTPS ports in published Workers: the custom port will be ignored when the Worker is published using the "wrangler deploy" command.
The text was updated successfully, but these errors were encountered: