-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wrangler): Display correct global flags in wrangler pages --help
#5814
Conversation
🦋 Changeset detectedLatest commit: b324b6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9100082012/npm-package-wrangler-5814 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5814/npm-package-wrangler-5814 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9100082012/npm-package-wrangler-5814 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9100082012/npm-package-create-cloudflare-5814 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9100082012/npm-package-cloudflare-kv-asset-handler-5814 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9100082012/npm-package-miniflare-5814 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9100082012/npm-package-cloudflare-pages-shared-5814 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9100082012/npm-package-cloudflare-vitest-pool-workers-5814 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
b4edbcc
to
9eb077d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subject to the wording change!
`wrangler pages --help` currently displays a list of global flags that are not all supported by Pages, such as `--env`, `--config`, and `--experimental-json-config`. This commit ensure that only flags that apply to Pages are listed when running `--help`. Fixes #5725
9eb077d
to
b324b6d
Compare
What this PR solves / how to test
Running
wrangler pages --help
will list, amongst others, the following global flags:Some of these global flags however, such as
--env
,--config
or--experimental-json-config
, are not supported by Pages, and therefore listing them as if they were gets users confused.This PR ensures we only list the relevant flags when running
wrangler pages --help
Fixes #5725.
Before
![Screenshot 2024-05-13 at 19 18 22](https://private-user-images.githubusercontent.com/4638332/330147629-4deedc4d-4075-44ca-92c9-394e29513f14.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTg3NjcsIm5iZiI6MTczOTY5ODQ2NywicGF0aCI6Ii80NjM4MzMyLzMzMDE0NzYyOS00ZGVlZGM0ZC00MDc1LTQ0Y2EtOTJjOS0zOTRlMjk1MTNmMTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDkzNDI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDcxNzM5MzlmOWVmNTE2MzFmMmY2MjJjNjk2MGJlMmZhMDQxYThlYjM0OGFiYWY2ODkxMWFmNmJmYjU2NjJhNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.O8rPGtXvPVzDoUXfU2x4QfPv5FjHnlIH2_pDT4GWkN0)
wrangler --help
wrangler pages --help
After
![Screenshot 2024-05-13 at 19 18 22](https://private-user-images.githubusercontent.com/4638332/330147629-4deedc4d-4075-44ca-92c9-394e29513f14.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTg3NjcsIm5iZiI6MTczOTY5ODQ2NywicGF0aCI6Ii80NjM4MzMyLzMzMDE0NzYyOS00ZGVlZGM0ZC00MDc1LTQ0Y2EtOTJjOS0zOTRlMjk1MTNmMTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDkzNDI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDcxNzM5MzlmOWVmNTE2MzFmMmY2MjJjNjk2MGJlMmZhMDQxYThlYjM0OGFiYWY2ODkxMWFmNmJmYjU2NjJhNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.O8rPGtXvPVzDoUXfU2x4QfPv5FjHnlIH2_pDT4GWkN0)
wrangler --help
wrangler pages --help
wrangler pages dev --help
Author has addressed the following