Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Some global flags listed by wrangler pages --help do not apply to Pages #5725

Closed
CarmenPopoviciu opened this issue Apr 29, 2024 · 0 comments · Fixed by #5814
Closed

🐛 BUG: Some global flags listed by wrangler pages --help do not apply to Pages #5725

CarmenPopoviciu opened this issue Apr 29, 2024 · 0 comments · Fixed by #5814
Assignees
@CarmenPopoviciu
Labels
bug Something that isn't working pages-dev Relating to `pages dev` command wrangler Relating to the Wrangler CLI tool
Milestone
Improvements for ...

Comments

@CarmenPopoviciu
Copy link
Contributor

CarmenPopoviciu commented Apr 29, 2024 •
edited
Loading

Which Cloudflare product(s) does this pertain to?

Wrangler core

What version(s) of the tool(s) are you using?

3.52.0

What version of Node are you using?

16.17.0

What operating system and version are you using?

MacOS Sonoma 14.4.1

Describe the Bug

Observed behavior

Running wrangler pages --help will list, amongst others, the following global flags:
Screenshot 2024-04-29 at 22 08 34

As per our docs, these global flags should apply to all commands. However, that is not actually the case, since flags such as --config or --experimental-json-config are not supported for Pages.

Expected behavior

Running wrangler pages --help will list the correct supported flags, for a given command

Steps to reproduce

Run wrangler pages --help in your terminal

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

No response
@CarmenPopoviciu CarmenPopoviciu added bug Something that isn't working pages-dev Relating to `pages dev` command wrangler Relating to the Wrangler CLI tool labels Apr 29, 2024
@CarmenPopoviciu CarmenPopoviciu changed the title 🐛 BUG: global flags listed by wrangler --help do not apply to all commands 🐛 BUG: Global flags listed by wrangler --help do not apply to all commands Apr 29, 2024
@CarmenPopoviciu CarmenPopoviciu mentioned this issue Apr 29, 2024
Closed
@CarmenPopoviciu CarmenPopoviciu self-assigned this May 7, 2024
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk May 8, 2024
@CarmenPopoviciu CarmenPopoviciu moved this from Untriaged to In Progress in workers-sdk May 8, 2024
@CarmenPopoviciu CarmenPopoviciu changed the title 🐛 BUG: Global flags listed by wrangler --help do not apply to all commands 🐛 BUG: Some global flags listed by wrangler pages --help do not apply to Pages May 13, 2024
CarmenPopoviciu added a commit that referenced this issue May 13, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
0075091 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
@CarmenPopoviciu CarmenPopoviciu mentioned this issue May 13, 2024
Merged
12 tasks
CarmenPopoviciu added a commit that referenced this issue May 13, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
77c038d 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
CarmenPopoviciu added a commit that referenced this issue May 13, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
919d2f9 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
CarmenPopoviciu added a commit that referenced this issue May 13, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
b4edbcc 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
@CarmenPopoviciu CarmenPopoviciu moved this from In Progress to In Review in workers-sdk May 13, 2024
CarmenPopoviciu added a commit that referenced this issue May 13, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
9eb077d 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
CarmenPopoviciu added a commit that referenced this issue May 15, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
b324b6d 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
@github-project-automation github-project-automation bot moved this from In Review to Done in workers-sdk May 15, 2024
CarmenPopoviciu added a commit that referenced this issue May 15, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
7333054 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
CarmenPopoviciu added a commit that referenced this issue May 15, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help
65dc96b 
`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725
@CarmenPopoviciu CarmenPopoviciu mentioned this issue May 15, 2024
Merged
12 tasks
petebacondarwin pushed a commit that referenced this issue May 15, 2024
@CarmenPopoviciu
fix(wrangler): Display correct global flags in wrangler pages --help (
36cb22b 
#5849)

`wrangler pages --help` currently displays a list of global
flags that are not all supported by Pages, such as `--env`,
`--config`, and `--experimental-json-config`.

This commit ensure that only flags that apply to Pages are
listed when running `--help`.

Fixes #5725

Co-authored-by: Carmen Popoviciu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarmenPopoviciu CarmenPopoviciu

Labels
bug Something that isn't working pages-dev Relating to `pages dev` command wrangler Relating to the Wrangler CLI tool
Projects
workers-sdk
Archived in project
Milestone
Improvements for `wrangler pages dev`
Development

Successfully merging a pull request may close this issue.

fix(wrangler): Display correct global flags in wrangler pages --help cloudflare/workers-sdk
1 participant
@CarmenPopoviciu