feat: import .wasm modules in service worker format workers
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e681b66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
wrangler prerelease is available for testing: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1829576326/wrangler |
threepointone
force-pushed
the
wasm-modules
branch
from
32766b9 to
f70ad18
Compare
threepointone
commented
Feb 10, 2022
threepointone
force-pushed
the
wasm-modules
branch
from
f70ad18 to
66d53d0
Compare
petebacondarwin
approved these changes
Feb 11, 2022
packages/example-wasm-app/README.md
Outdated
| The wasm file generated, `index_bg.wasm` is copied into `./worker`, and shared by the 2 workers. `./worker/module` contains a "modules" format worker and imports the wasm module as a regular es module, while `./worker/service-worker` contains a "service-worker" format worker and uses wrangler.toml to bind the wasm module as a global `MYWASM`. They're otherwise identical. | ||
| The wasm file generated, `index_bg.wasm` is copied into `./worker`, and shared by the 3 workers. | ||
|
|
||
| - `./worker/module` contains a "modules" format worker and imports the wasm module as a regular es module. |
There was a problem hiding this comment.
NIT: Every where I look it is ES module not es module... 🤷
There was a problem hiding this comment.
Good point. I replaced it across the codebase.
Comment on lines
+68
to
+76
| contents: `export default ${args.path.replace( | ||
| /[^a-zA-Z0-9_$]/g, | ||
| "_" | ||
| )};`, |
There was a problem hiding this comment.
A comment explaining the point of this code would be helpful here.
There was a problem hiding this comment.
Added some comments. Do they look ok to you?
This allows importing `.wasm` modules in service worker format workers. We do this by hijacking imports to `.wasm` modules, and instead registering them under `[wasm_modules]` (building on the work from #409).
threepointone
force-pushed
the
wasm-modules
branch
from
66d53d0 to
e681b66
Compare
|
I missed the bit about |
|
Actually, lemme land this. We can change the comments whenever. |
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
…ts (#432) * Allow `string[]` for `kvNamespaces`/`r2Buckets` like Miniflare 2 In this case, the binding name is assumed to be the same as the namespace ID/bucket name. * Add API documentation
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
…ts (#432) * Allow `string[]` for `kvNamespaces`/`r2Buckets` like Miniflare 2 In this case, the binding name is assumed to be the same as the namespace ID/bucket name. * Add API documentation
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
…ts (#432) * Allow `string[]` for `kvNamespaces`/`r2Buckets` like Miniflare 2 In this case, the binding name is assumed to be the same as the namespace ID/bucket name. * Add API documentation
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
…ts (#432) * Allow `string[]` for `kvNamespaces`/`r2Buckets` like Miniflare 2 In this case, the binding name is assumed to be the same as the namespace ID/bucket name. * Add API documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows importing
.wasmmodules in service worker format workers. We do this by hijacking imports to.wasmmodules, and instead registering them under[wasm_modules](building on the work from #409).