feat: implement `[build.upload.rules]` for both service-worker/modules format workers #416

threepointone · 2022-02-08T12:36:46Z

One of wrangler2's highlights is having a first class module system, that brings it closer to runtimes like node/deno/etc. Further, we have pretty decent defaults ootb - common module types (js/jsx/ts/tsx/json) don't need any configuration, and non-"standard" modules (wasm/txt/html) work as expected. There are a few corner cases though, and a little more we can do to make this story feel more complete.

importing .wasm modules should 'just work' in service-worker format workers. We already do the same for standard and the other non-standard module types, so this would just complete the story. (It would be implemented on top of feat: support [wasm_modules] for service-worker format workers #409) - fixed in feat: import .wasm modules in service worker format workers #432
wrangler 1 supports [build.upload.rules]for es module workers, and so should wrangler 2, but for both modules and service-worker formats. The most common usecase is to add more extensions to be recognised as Text, but I'd imagine some folks will want Data as well.

(This work is separate from the work for plugins (#367), which we'll get to later.)

The text was updated successfully, but these errors were encountered:

threepointone · 2022-02-28T23:32:39Z

Most of this was done in #530, but some followups before we can close this

non-wasm modules don't work in local mode (I think I can fix this)
Data type does not work in service worker format, in either mode (because there isn't an analog to wasm_module/text_blob binding for a Data module, unless I'm missing something)

threepointone · 2022-03-08T16:00:00Z

I proposed a partial fix for this in cloudflare/miniflare#205

This rewrites how we pass configuration to miniflare in `wrangler dev`'s local mode. Instead of passing the entire configuration as cli args, we now generate a `wrangler.toml` based on our generated/inferred configuration, and pass that to miniflare instead. This solves a couple of issues, notably - - `text_blobs` now works in local mode+service-worker format - `Text` modules now work in local mode+service-worker format - We properly throw errors for `Data` module in service-worker format Along with cloudflare/miniflare#205, this fixes #416.

threepointone · 2022-03-09T17:50:22Z

for text_blobs/Text modules support in local mode, blocked on cloudflare/miniflare#211. After that, we can land #558 and close this. Unassigning from myself.

caass · 2022-03-30T11:58:07Z

Opened cloudflare/miniflare#228 with more hope than tangible code

threepointone · 2022-03-31T03:22:38Z

Deeply grateful to @caass for working on this with @mrbbot to land support in miniflare! Thanks thanks.

@caass

This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416

@caass

This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416

@caass

This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416

@caass

This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416

@caass

…ode (#735) This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416

threepointone · 2022-03-31T15:24:57Z

reopening this, waiting for the miniflare update, as well as needing to add data_blob bindings (#740)

threepointone · 2022-04-03T00:51:24Z

importing text and data modules now works in service workers+local mode, but not plain text_blobs/data_blobs. we probably have to copy it here https://github.com/cloudflare/wrangler2/blob/b9336414c3c1ac20ba34d274042886ea802385d9/packages/wrangler/src/dev/local.tsx#L75-L82 I'll fix this tomorrow unless someone else gets to it

For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths so that they're ersolveds correctly by miniflare. Fixes #740 Fixes #416

For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as asbolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`. Fixes #740 Fixes #416

For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`. Fixes #740 Fixes #416

…#756) For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths as absolute so that they're resolved correctly by miniflare. This also expands some coverage for local mode `wrangler dev`. Fixes #740 Fixes #416

) - Upgrade to `ava@5` - Port `KVNamespace` tests from Miniflare 2 - Only throw if `cacheTtl` is invalid, not just specified - Return `cursor: undefined` on the last page to match the behaviour of the Worker's runtime

threepointone added this to workers-sdk Feb 8, 2022

Electroid added the feature label Feb 8, 2022

Electroid added this to the 2.0 milestone Feb 8, 2022

Electroid moved this to Blocking in workers-sdk Feb 8, 2022

threepointone mentioned this issue Feb 9, 2022

feat: support [wasm_modules] #392

Closed

threepointone self-assigned this Feb 25, 2022

threepointone moved this from Must-have to In Progress in workers-sdk Feb 28, 2022

threepointone removed their assignment Mar 1, 2022

threepointone moved this from In Progress to Must-have in workers-sdk Mar 1, 2022

threepointone mentioned this issue Mar 8, 2022

generate "real" paths for identifiers when linking modules. cloudflare/miniflare#205

Closed

threepointone mentioned this issue Mar 8, 2022

WIP fix: module support in service-worker format workers #558

Closed

threepointone moved this from Must-have to In Review in workers-sdk Mar 8, 2022

threepointone self-assigned this Mar 8, 2022

threepointone moved this from In Review to Must-have in workers-sdk Mar 9, 2022

threepointone removed their assignment Mar 9, 2022

petebacondarwin added the blocked Blocked on other work label Mar 15, 2022

caass self-assigned this Mar 24, 2022

threepointone mentioned this issue Mar 31, 2022

text_blobs/Text module support for service worker format in local mode #735

Merged

threepointone closed this as completed in #735 Mar 31, 2022

Repository owner moved this from Must-have to Done in workers-sdk Mar 31, 2022

threepointone reopened this Mar 31, 2022

Repository owner moved this from Done to In Progress in workers-sdk Mar 31, 2022

threepointone mentioned this issue Apr 3, 2022

feat: Implement support for [data_blobs]/Data modules for service-workers #740

Closed

threepointone added a commit that referenced this issue Apr 4, 2022

fix: resolve raw file bindings correctly in local mode

d046b92

For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths so that they're ersolveds correctly by miniflare. Fixes #740 Fixes #416

threepointone added a commit that referenced this issue Apr 4, 2022

fix: resolve raw file bindings correctly in local mode

963b28d

For `wasm_modules`/`text_blobs`/`data_blobs` in local mode, we need to rewrite the paths so that they're ersolveds correctly by miniflare. Fixes #740 Fixes #416

threepointone mentioned this issue Apr 4, 2022

fix: resolve raw file bindings correctly in wrangler dev local mode #756

Merged

threepointone closed this as completed in #756 Apr 4, 2022

Repository owner moved this from In Progress to Done in workers-sdk Apr 4, 2022

github-actions bot mentioned this issue Apr 4, 2022

Version Packages #721

Merged

workers-frameworks removed this from workers-sdk Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement `[build.upload.rules]` for both service-worker/modules format workers #416

feat: implement `[build.upload.rules]` for both service-worker/modules format workers #416

threepointone commented Feb 8, 2022 •

edited

Loading

threepointone commented Feb 28, 2022

threepointone commented Mar 8, 2022

threepointone commented Mar 9, 2022

caass commented Mar 30, 2022

threepointone commented Mar 31, 2022

threepointone commented Mar 31, 2022

threepointone commented Apr 3, 2022

feat: implement [build.upload.rules] for both service-worker/modules format workers #416

feat: implement [build.upload.rules] for both service-worker/modules format workers #416

Comments

threepointone commented Feb 8, 2022 • edited Loading

threepointone commented Feb 28, 2022

threepointone commented Mar 8, 2022

threepointone commented Mar 9, 2022

caass commented Mar 30, 2022

threepointone commented Mar 31, 2022

threepointone commented Mar 31, 2022

threepointone commented Apr 3, 2022

feat: implement `[build.upload.rules]` for both service-worker/modules format workers #416

feat: implement `[build.upload.rules]` for both service-worker/modules format workers #416

threepointone commented Feb 8, 2022 •

edited

Loading