Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve fixture test reliability/debugability #3863

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Aug 29, 2023

What this PR solves / how to test:

Hey! 👋 This PR was part of debugging steps for #3799. We're not merging that PR, but these changes should still help to improve overall reliability and debugability of fixture tests. 🙂

  • Only call stop() when beforeAll() hooks succeed
  • Call stop()s in finally-blocks to ensure cleanup
  • Add timeout to runLongLivedWrangler() and log stdout/stderr

Associated docs issue(s)/PR(s):

N/A

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

- Only call `stop()` when `beforeAll()` hooks succeed
- Call `stop()`s in `finally`-blocks to ensure cleanup
- Add timeout to `runLongLivedWrangler()` and log `stdout`/`stderr`
@mrbbot mrbbot requested review from a team as code owners August 29, 2023 16:01
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

⚠️ No Changeset found

Latest commit: b44566a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6014709700/npm-package-wrangler-3863

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6014709700/npm-package-wrangler-3863

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6014709700/npm-package-wrangler-3863 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6014709700/npm-package-cloudflare-pages-shared-3863

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230814.1 3.20230814.1
workerd 1.20230814.1 1.20230814.1

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@1000hz 1000hz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @mrbbot!

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3863 (b44566a) into main (d21530a) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3863      +/-   ##
==========================================
+ Coverage   75.25%   75.27%   +0.02%     
==========================================
  Files         195      195              
  Lines       11452    11452              
  Branches     3022     3022              
==========================================
+ Hits         8618     8621       +3     
+ Misses       2834     2831       -3     

see 2 files with indirect coverage changes

@mrbbot mrbbot merged commit a2f71e6 into main Aug 29, 2023
@mrbbot mrbbot deleted the bcoll/fixture-test-debuggability branch August 29, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants