Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump miniflare to 3.20230821.0 #3799

Closed
wants to merge 4 commits into from

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Aug 22, 2023

What this PR solves / how to test:

Hey! 👋 This PR bumps miniflare to 3.20230821.0. Whilst this won't cause major user facing changes on its own, it's a pre-requisite for #3726 and #3774.

Associated docs issue(s)/PR(s):

N/A

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested review from a team as code owners August 22, 2023 10:26
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: 8b639a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/pages-shared Minor
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrbbot mrbbot force-pushed the bcoll/miniflare-3.20230821.0 branch from 871cf98 to f5ede1c Compare August 22, 2023 10:27
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5944538745/npm-package-wrangler-3799

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5944538745/npm-package-wrangler-3799

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5944538745/npm-package-wrangler-3799 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5944538745/npm-package-cloudflare-pages-shared-3799

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #3799 (0b303ec) into main (c053403) will increase coverage by 0.09%.
Report is 2 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head 0b303ec differs from pull request most recent head d74e1ed. Consider uploading reports for the commit d74e1ed to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3799      +/-   ##
==========================================
+ Coverage   75.26%   75.36%   +0.09%     
==========================================
  Files         195      195              
  Lines       11450    11430      -20     
  Branches     3020     3018       -2     
==========================================
- Hits         8618     8614       -4     
+ Misses       2832     2816      -16     
Files Changed Coverage Δ
packages/wrangler/src/r2/index.ts 87.30% <66.66%> (ø)

... and 4 files with indirect coverage changes

@mrbbot mrbbot marked this pull request as draft August 22, 2023 20:01
@mrbbot mrbbot force-pushed the bcoll/miniflare-3.20230821.0 branch 4 times, most recently from 0b303ec to 8a7c599 Compare August 24, 2023 22:15
mrbbot added 3 commits August 25, 2023 16:22
- Only call `stop()` when `beforeAll()` hooks succeed
- Call `stop()`s in `finally`-blocks to ensure cleanup
- Add timeout to `runLongLivedWrangler()` and log `stdout`/`stderr`
@mrbbot mrbbot force-pushed the bcoll/miniflare-3.20230821.0 branch from 6125823 to d74e1ed Compare August 25, 2023 15:23
@mrbbot
Copy link
Contributor Author

mrbbot commented Aug 29, 2023

Skipping this version bump. We'll bump miniflare once a version that depends on workerd with cloudflare/workerd#1077 has been released. 👍

@mrbbot mrbbot closed this Aug 29, 2023
@mrbbot mrbbot deleted the bcoll/miniflare-3.20230821.0 branch August 29, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant