Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

User invite error handling #1105

Merged
merged 16 commits into from
May 30, 2017
Merged

User invite error handling #1105

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e6550d3
Attempt to fix failing test
May 24, 2017
907f16c
Fix problem with how test being resolved
May 24, 2017
5164e9c
Add user invite error to be called
May 24, 2017
41d9ea4
It should call user error when cf create user fails
May 24, 2017
741c9f1
User invite error action shoudl dispatch error
May 24, 2017
31b4b90
Rename to global user error
May 24, 2017
faf889f
Add contextual message to global error action
May 24, 2017
816a0cd
Add specific user information to error messages
May 24, 2017
72f098b
Add error messaging when user association fails
May 24, 2017
c55d771
Remember to rename to correct constant
May 24, 2017
dfb418b
Changed backed to invite error
May 25, 2017
3204c30
User store adds invite error when action happens
May 25, 2017
8e3117f
Reset user invite error when fetched again
May 25, 2017
01ef7da
Add error message to UI
May 25, 2017
38bf31c
Removed unused dep
May 25, 2017
5853d1c
Add test for error message
May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion static_src/components/users_invite.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import React from 'react';

import Action from './action.jsx';
import ErrorMessage from './error_message.jsx';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to lint for unused dependencies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.

This looks like it does it: https://github.com/depcheck/depcheck

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when does it get called? i didn't see an error for it in the build before it was fixed.

import FormStore from '../stores/form_store';
import { Form, FormText } from './form';
import PanelDocumentation from './panel_documentation.jsx';
Expand Down