This repository has been archived by the owner on May 19, 2020. It is now read-only.
User invite error handling #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm getting the following failure:
```
cfApi deleteOrgUserPermissions() should call an http delete request on org user with permissions FAILED
Expected spy "delete" (empty string)to have been called once. "delete" was called twice.
```
I'm guessing it's because of issues with promises in the API file
where not all of them are working async correcty by using done
and then statements.
In promise async code it was calling
When the user invite request fails so we can show error messaging to the user.
As this is part of the invite user flow, so the user needs to know something went wrong.
So the store can receive it and take action on it.
So I can re-use it for any type of error that isn't specific to one user.
For when the invite process goes wrong.
So when the user invites somebody and something goes wrong, they know specifically what invite had the problem.
With slightly different error messaging. This is different because at this point, the user was invited, so the user would have to take a different action on their end.
Looking at the UI, I realized that putting these errors in a global context of the whole user list is not really correct, these should actually be tied with the invite form, as they're all related to that.
Which sets both the cf error object and adds a contextual error message set by us.
Required that uaa api code correctly unwrapped error message to expose actual object.
So if you submit a problematic email, we check that an error message is correctly displayed.
jcscottiii
reviewed
May 30, 2017
| @@ -7,7 +7,6 @@ | |||
| import React from 'react'; | |||
|
|
|||
| import Action from './action.jsx'; | |||
| import ErrorMessage from './error_message.jsx'; | |||
There was a problem hiding this comment.
is there a way to lint for unused dependencies?
There was a problem hiding this comment.
Good question.
This looks like it does it: https://github.com/depcheck/depcheck
There was a problem hiding this comment.
when does it get called? i didn't see an error for it in the build before it was fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error handling for user invite feature. Ensures at any part of the 3 step request process, that if something goes wrong, there's an error added in the form for the user.