Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core - fix value filters that specify a value type but no op #6682

Merged
merged 1 commit into from
May 17, 2021

Conversation

ajkerrigan
Copy link
Member

When processing a filter with a value type defined, be sure that all
comparisons target the converted value.

This addresses an edge case with value filters that specify a
value type but no op - the fallback equality test compared against the
pre-converted value.

When processing a filter with a value type defined, be sure that all
comparisons target the converted value.

This addresses an edge case with value filters that specify a
value type but no op - the fallback equality test compared against the
pre-converted value.
@ajkerrigan ajkerrigan requested a review from kapilt as a code owner May 14, 2021 18:13
Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@kapilt kapilt merged commit 6734a45 into cloud-custodian:master May 17, 2021
@ajkerrigan ajkerrigan deleted the fix/value-filter branch May 17, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants