Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value_type expr checking #1617

Closed
kapilt opened this issue Oct 3, 2017 · 2 comments
Closed

value_type expr checking #1617

kapilt opened this issue Oct 3, 2017 · 2 comments
Labels

Comments

@kapilt
Copy link
Collaborator

kapilt commented Oct 3, 2017

at the moment running this policy results in an error, instead of finding all buckets with Name == tag value of App. What happens when running through is that the value of bucket Name ('xyz') is passed in as the jmespath expression instead of the filter value. There's some unit tests that seem dependent on the extant logic though.

policies:
  - name: s3-named
    resource: s3
    filters:
     - type: value
       key: Name
       value: tag:App
       value_type: expr```

@Sutto
Copy link
Contributor

Sutto commented Mar 23, 2018

This happens because the value_type filter is applied to the resource value (specified from the key field), not from the value itself (as far as I can tell) - I need to confirm but I'll have a patch for this shortly.

@ajkerrigan
Copy link
Member

Looks like this was resolved in #2148, though confirming that revealed a separate edge case (which should be fixed via #6682)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants