Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #506] Makes display version command return the actual version (2) #515

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

carlosgeos
Copy link
Contributor

@carlosgeos carlosgeos commented Feb 28, 2019

My previous PR (#507), only partially solves the problem (#506)

The byte-compiled file will look for the version in its headers but it has none.

The version has to be given to the byte compiled file at compile time (therefore using eval-when-compile).

Difference in the .elc files:
This PR:
screenshot_20190228_022353

master branch:
screenshot_20190228_022436


And a small change: (lm-version) takes an argument, the file. This is cleaner than creating a temp buffer, inserting the contents of the current file and calling (lm-version) within this context.


  • The commits are consistent with our [contribution guidelines][1].
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

@bbatsov
Copy link
Member

bbatsov commented Feb 28, 2019

The commit message doesn’t seem right. I guess you can use a variation of your PR description instead.

`clojure-mode-display-version` was displaying nil when clojure-mode.elc was
loaded, since (lm-version) had no access to the file headers.
@bbatsov bbatsov merged commit a1d6a0f into clojure-emacs:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants