-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clojure-mode-display-version not working #506
Comments
lower case v for version in file headers
The problem seems to be The following code works for me (defconst clojure-mode-version
(with-current-buffer (find-file-noselect "~/.emacs.d/elpa/clojure-mode-20190105.1043/clojure-mode.el")
(lm-version))
"The current version of `clojure-mode'.") So this works too: (defconst clojure-mode-version
(with-current-buffer (find-file-noselect load-file-name)
(lm-version))
"The current version of `clojure-mode'.") And using something like If loading, the buffer would have to be closed afterwards. Otherwise Emacs starts with a Should I submit a PR with these changes, or with a simple constant (dropping (lm-version)) ? |
the the content should be (at least) the headers up to Version, so that (lm-version) can fetch it.
lower case v for version in file headers
the the content should be (at least) the headers up to Version, so that (lm-version) can fetch it.
[Fix clojure-emacs#506] fix clojure-mode-display-version
This issue still persists, the problem occurs when emacs loads the byte compiled file |
…al version `clojure-mode-display-version` displays the correct version (was displaying nil) also added some tests
…al version `clojure-mode-display-version` displays the correct version (was displaying nil) also added some tests
`clojure-mode-display-version` was displaying nil when clojure-mode.elc was loaded, since (lm-version) had no access to the file headers.
`clojure-mode-display-version` was displaying nil when clojure-mode.elc was loaded, since (lm-version) had no access to the file headers.
Expected behavior
Running
clojure-mode-display-version
should return:clojure-mode (version 5.10.0)
Actual behavior
Returns
clojure-mode (version nil)
Steps to reproduce the problem
Start Emacs. Open a .clj buffer. Run
clojure-mode-display-version
Environment & Version information
clojure-mode version information
wish I could
Emacs version
26.1
Operating system
Biebian
PR submitted
The text was updated successfully, but these errors were encountered: