Isolate nrepl-client connection logic from CIDER
#903
Conversation
vspinu
force-pushed
the
isolate-nrepl
branch
from
43fd495
to
fa45681
Compare
|
I'll review this after I'm done with the bugfixes scheduled for 0.8.2. While I don't mind splitting cider and nrepl, I have a feeling this will be problematic/hard and I'm not overly eager to deal with this right now. |
| (defcustom cider-connected-hook nil | ||
| "List of functions to call when connected to Clojure nREPL server." | ||
| :type 'hook | ||
| :group 'cider) |
There was a problem hiding this comment.
These are missing package-version properties.
There was a problem hiding this comment.
These are missing package-version properties.
I wonder if the defcustom is really needed here. I added them because defcustom was used fornrepl-connection-hook.
|
This needs a changelog entry. |
vspinu
force-pushed
the
isolate-nrepl
branch
from
fa45681
to
25e5327
Compare
All set. |
| "List of functions to call when connected to Clojure nREPL server." | ||
| :type 'hook | ||
| :group 'cider | ||
| :version "0.8.2") |
vspinu
force-pushed
the
isolate-nrepl
branch
2 times, most recently
from
ce1fd09
to
0cc3d7b
Compare
|
All fixed. |
| nrepl-connection-buffer client-buf | ||
| nrepl-repl-buffer (when replp client-buf) | ||
| nrepl-repl-buffer client-buf | ||
| nrepl-buffer-ns "user" |
There was a problem hiding this comment.
This is no longer needed. See the commit which made nrepl-buffer-ns more generic.
There was a problem hiding this comment.
I got confused with most recent conflicts. I thought that you have just added that line. Fixed.
Allow `nrepl-client` to be used by non CIDER frontends. - Frontends can control the creation of the client buffer through `nrepl-create-client-buffer-function`. - Each frontend has it's own `xxx-connected-hook` which is run by `xxx--connected-handler`. The latter function is placed in the local `nrepl-connected-hook` during the client buffer initialization. Similarly for `xxx-disconnected-hook`. - Rename `nrepl--init-connection-buffer` -> nrepl--init-capabilities
vspinu
force-pushed
the
isolate-nrepl
branch
from
0cc3d7b
to
f42ef6d
Compare
Isolate `nrepl-client` connection logic from CIDER
Hi Bozhidar,
I have just writen a nREPL client and server for R and with this patch I can sucesfuly connect/jack-in. There are a bunch of other, less critical, cider links that must be broken. I will be addressing those gradually.
I hope you would be fine with spliting nrepl into a separte package eventually.
Thanks.
Allow
nrepl-clientto be used by non CIDER frontends.nrepl-create-client-buffer-function.xxx-connected-hookwhich is run byxxx--connected-handler. The latter function is placed in the localnrepl-connected-hookduring the client buffer initialization. Similarly forxxx-disconnected-hook.nrepl--init-connection-buffer-> nrepl--init-capabilities