Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*nrepl-server* buffer disappears after cider-restart #912

Closed
cch1 opened this issue Dec 7, 2014 · 7 comments
Closed

*nrepl-server* buffer disappears after cider-restart #912

cch1 opened this issue Dec 7, 2014 · 7 comments

Comments

@cch1
Copy link

cch1 commented Dec 7, 2014

The nrepl buffer disappears after a cider-restart or even a cider-quit followed by a cider-jack-in. Very annoying, and the only solution (that I can discern) is to quit emacs and restart.

This problem has been happening for a while, and is definitely still happening with 0.8.2-SNAPSHOT.

Issue #818 details another problem with the nrepl buffer not scrolling -a desireable enhancement.

@bbatsov
Copy link
Member

bbatsov commented Dec 7, 2014

The nrepl buffer disappears after a cider-restart or even a cider-quit followed by a cider-jack-in. Very annoying, and the only solution (that I can discern) is to quit emacs and restart.

I'll have a look at this, although I can't imagine what might go wrong there - after all the restart simply stops everything and starts it again. Btw, this buffer is present only for local connections created with cider-jack-in as it's the buffer of the lein repl process (not the actual nREPL connection).

Issue #818 details another problem with the nrepl buffer not scrolling -a desireable enhancement.

Not going to happen. As I've said several times - the appearance of the output there is a bug and we should solve it instead.

@bbatsov
Copy link
Member

bbatsov commented Dec 7, 2014

I noticed cider-restart misbehaved if invoked outside the directory of the project, but other than that - restarts seem to work fine for me.

@vspinu
Copy link
Contributor

vspinu commented Dec 7, 2014

I think this can be safely marked as duplicate of #732.

@vspinu
Copy link
Contributor

vspinu commented Dec 7, 2014

nrepl-server is associated with connection, so when connection is closed it's natural to close the nrepl-server buffer.

The real question is if it would be meaningfull to reuse the nrepl-server on restart. I think it is. It is also meaningful to reuse the current REPL buffer. I would even like to have REPL buffer preserved on cider-quit, so I can start a new connection within that buffer.

@bbatsov
Copy link
Member

bbatsov commented Dec 7, 2014

The real question is if it would be meaningfull to reuse the nrepl-server on restart. I think it is. It is also meaningful to reuse the current REPL buffer. I would even like to have REPL buffer preserved on cider-quit, so I can start a new connection within that buffer.

I'd accept a PR implementing this, but there should also be an option to close the REPL buffer on quit.

@vspinu
Copy link
Contributor

vspinu commented Dec 7, 2014

I'd accept a PR implementing this, but there should also be an option to close the REPL buffer on quit.

This fits into my plans of refactoring Ciders's connection and REPL management as a whole. We have discussed this on multiple ocassions so far. I am waiting for you to pull #903 and for 0.8.2 to be released before I start with it. The changes will touch quite a bit of code, and I don't want to pile commits and then fix conflicts after each minor change to the mainstream. Any ideas of when 0.8.2 could be out?

@bbatsov
Copy link
Member

bbatsov commented Dec 7, 2014

0.8.2 is stuck on a single issue #885. Hopefully I'll be able to debug and fix it this week, but I won't mind it if someone beats me to it.

@bbatsov bbatsov closed this as completed Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants