#460 nrepl-complete support #461
Conversation
| @@ -515,6 +515,10 @@ instance, because nREPL itself does not depend on `clojure-complete`. | |||
| Note that if you're using an nREPL middleware providing a `complete` op, | |||
| CIDER will use it instead of its built-in completion. | |||
|
|
|||
| Clojurescript completion is provided by the [nrepl-complete](https://github.com/gtrak/nrepl-complete) middleware. | |||
There was a problem hiding this comment.
I guess you didn't understand me in the comments - the nrepl completion middleware should be part of the cider-nrepl project. That's the only way to ensure the middleware will always be in sync with cider. Other projects will obviously be welcome to use cider's middleware, but compatibility with them will not be a priority.
There was a problem hiding this comment.
Ah, I don't quite understand the relationship between nrepl and cider, I guess. The middleware makes no requirement on cider. I assumed you meant that cider-nrepl will simply pull it in and wrap handlers with it.
There was a problem hiding this comment.
Another implication of this is that cider-nrepl is going to have to be aware of piggieback and whatever else might be needed (ritz, maybe?). I couldn't tell if that's within its design scope. But, throwing this into cider-nrepl is fine by me. Once it's in, I'll kill my nrepl-complete repo. Seems like we can also remove the doc middleware once #462 is addressed.
There was a problem hiding this comment.
The endgame is that cider own middleware (from cider-nrepl) will replace ritz's middleware. Long term essential ritz components should be absorbed into cider proper (like the debugger, appropos, etc). Currently as they are developed independently they are often out of sync - ritz is still not updated for cider.
|
Looks good. Just squash the 4 commits together. |
#460