Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-jump-to-def should use a 'var-info' op if present. #462

Closed
gtrak opened this issue Jan 25, 2014 · 1 comment
Closed

cider-jump-to-def should use a 'var-info' op if present. #462

gtrak opened this issue Jan 25, 2014 · 1 comment

Comments

@gtrak
Copy link
Contributor

gtrak commented Jan 25, 2014

Much like nrepl-complete [#460], we need an op and nrepl middleware to remove the reliance on 'eval' for cljs support.

Current code builds a huge string:
https://github.com/clojure-emacs/cider/blob/master/cider-interaction.el#L492

I am happy to work on such a middleware. If needed, I can try to implement the elisp op call and eval fallback.

var-info will take an ns and var name and return file+line, doc, arglists and whatever else is in common between clj and cljs.

@bbatsov
Copy link
Member

bbatsov commented Jan 25, 2014

Indeed. Such a middleware should also be part of cider-nrepl. My long term plan is to remove all non-trivial & non-portable inlined code and to replace it with nREPL middleware.

gtrak added a commit to gtrak/cider that referenced this issue Jan 31, 2014
bbatsov added a commit that referenced this issue Feb 7, 2014
re #462 - jump-to-def via 'info' op
@bbatsov bbatsov closed this as completed Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants