Add sensible category overrides for cider
#3504
Conversation
cider-completion.el
Outdated
| ;; Currently CIDER completions only work for `basic`, and not `flex` `initials` `partial-completion`, `orderless`, etc. | ||
| ;; So we ensure that those other styles aren't used with CIDER, otherwise one would see bad or no completions at all. | ||
| ;; This `add-to-list` call can be removed once we implement the other completion styles. | ||
| (add-to-list 'completion-category-overrides '(cider (styles basic))) |
There was a problem hiding this comment.
Something like this should not be at the top-level IMO, but rather at the mode init. (and should be cleaned when CIDER is disabled). It's not nice for packages to pollute the Emacs global config at load time.
There was a problem hiding this comment.
I understand the concern, however we already perform add-to-list 'completion-styles-alist '(cider above these LOCs.
If we define cider globally, it seems only fair to also declare globally the extent of usefulness of cider.
The impact of the customization is limited to our own completion style, so the alternative would not add much IMO and would be harder to keep track of (vs. having everything in contiguous LOCs)
There was a problem hiding this comment.
Hmm, it seem to me that the preceding expression should have been in the mode setup as well. It's not a big deal in general - obvious the code will work either way. It's more about mode hygiene and not making permanent modifications to global settings.
There was a problem hiding this comment.
I'd be concerned about having too many moving pieces to achieve an otherwise harmless thing.
Since we only affect cider aspects here, all modifications are 'namespaced' and aren't too different from e.g. defuns (which also techically alter the global environment).
There was a problem hiding this comment.
As I said - it's just a matter of modes keeping tidy after themselves. Obviously this completion backend is mostly useless without cider-mode being active. But there's not much point in discussing this - it will work as it is and it's not a big deal.
Yeah, I never got to investigating what's actually needed for those. I'm OK with those changes provided they don't break the fuzzy completion (which Emacs calls "flex") in |
|
We should also document this somewhere (what's supported and what's not - seems we don't support much today). |
This possibility was enabled by #3226 It can be seen in use in SystemCrafters/crafted-emacs#241 or https://clojurians.slack.com/archives/C0617A8PQ/p1696684010392119?thread_ts=1696618691.247989&cid=C0617A8PQ| It provides a better default experience for those using orderless or other newer styles.
vemv
force-pushed
the
completion-category-overrides
branch
from
295b84e
to
502c78c
Compare
|
I added doc as well. |
This possibility was enabled by #3226
It can be seen in use in SystemCrafters/crafted-emacs#241 or https://clojurians.slack.com/archives/C0617A8PQ/p1696684010392119?thread_ts=1696618691.247989&cid=C0617A8PQ|
It provides a better default experience for those using
orderlessor other newer styles.(Ideally we'd just do whatever is needed to implement
orderlessetc, but we have plenty of stuff on the table. Anyone can pick up #3019 (comment))Cheers - V