Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add falback completion style #241

Merged

Conversation

petervlk
Copy link
Contributor

@petervlk petervlk commented Oct 10, 2022

This PR adds a fallback completion style as recommended by author of orderless in the projects docs.

It helps to solve completion issue where namespace prefix is being ignored.

The proposed solution was found here.

@petervlk
Copy link
Contributor Author

Alternative is to set this specifically for cider.

(setq completion-category-defaults '((cider (styles basic)))

@jeffbowman
Copy link
Contributor

Nice change, thanks for the PR!

@jeffbowman jeffbowman merged commit 3243e9e into SystemCrafters:master Oct 10, 2022
@petervlk petervlk deleted the feature/fallback-completion-style branch October 11, 2022 08:00
vemv added a commit to clojure-emacs/cider that referenced this pull request Oct 8, 2023
This possibility was enabled by #3226

It can be seen in use in SystemCrafters/crafted-emacs#241 or https://clojurians.slack.com/archives/C0617A8PQ/p1696684010392119?thread_ts=1696618691.247989&cid=C0617A8PQ|

It provides a better default experience for those using orderless or other newer styles.
vemv added a commit to clojure-emacs/cider that referenced this pull request Oct 8, 2023
This possibility was enabled by #3226

It can be seen in use in SystemCrafters/crafted-emacs#241 or https://clojurians.slack.com/archives/C0617A8PQ/p1696684010392119?thread_ts=1696618691.247989&cid=C0617A8PQ|

It provides a better default experience for those using orderless or other newer styles.
vemv added a commit to clojure-emacs/cider that referenced this pull request Oct 8, 2023
This possibility was enabled by #3226

It can be seen in use in SystemCrafters/crafted-emacs#241 or https://clojurians.slack.com/archives/C0617A8PQ/p1696684010392119?thread_ts=1696618691.247989&cid=C0617A8PQ|

It provides a better default experience for those using orderless or other newer styles.
bbatsov pushed a commit to clojure-emacs/cider that referenced this pull request Oct 9, 2023
This possibility was enabled by #3226

It can be seen in use in SystemCrafters/crafted-emacs#241 or https://clojurians.slack.com/archives/C0617A8PQ/p1696684010392119?thread_ts=1696618691.247989&cid=C0617A8PQ|

It provides a better default experience for those using orderless or other newer styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants