Make it possible to cider-find-var in another window

[joncol]

This fix makes it possible to use - prefix (M-- t) to jump to test definition in another window. Before this fix, pressing enter (or t) in the CIDER test report buffer always opened the definition of the failing test function in the same window as the test report.

---

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (make test)
• All code passes the linter (make lint) which is based on elisp-lint and includes
  • byte-compilation, checkdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.

[bbatsov]

Did you start experiencing this problem recently? It seems to me that changing the default here #2757 might have been a bad idea for such use cases.

[joncol]

Did you start experiencing this problem recently? It seems to me that changing the default here #2757 might have been a bad idea for such use cases.

Yes, I think it started showing up around that time. Not 100 % sure though. I at least think it used to work differently.

The specific case where it currently doesn't work as I want, is when standing in the test report buffer and navigating to the test definition. I almost never want the test report to be hidden then. I thought I'd change this by adding a custom binding to include the prefix (C-u - or M--) when in the test report mode, but maybe some other solution is better?

[joncol]

OK, after reading #2757 and using

(setq cider-jump-to-pop-to-buffer-actions
      '((display-buffer-reuse-window display-buffer-same-window)))

it works as I want.

I guess this PR can be closed then.

[bbatsov]

Let's keep it open for now until I restore the previous default value. When it was changed we didn't account the impact of the new default to cases like this one.