Add cider-jump-to-pop-to-buffer-actions

[simon-katz]

Provide a means to control what window to use when jumping to a definition with cider-jump-to.

By default, always use current window. (FWIW, note that this matches the behaviour of M-. in .el files.)

Provide an option to use an existing window in current frame when there is one that
is showing the target buffer. This is the old behaviour, but note that it does
not work well with cider-pop-back (M-,).

---

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (make test)
• All code passes the linter (make lint) which is based on elisp-lint and includes
  • byte-compilation, checkdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the user manual (if adding/changing user-visible functionality)

[bbatsov]

Great work! I've left a few small comments, but I finally understand what the problem is (and why I never encountered it).

[simon-katz]

I've pushed changes, and linting is complaining about this in a doc string:

A value of `((display-buffer-reuse-window display-buffer-same-window))`
means if target buffer is being displayed in the current frame use its
window, otherwise use the current window.

The complaint is: Lisp symbol `display-buffer-same-window' should appear in quotes.

Is this a bug in the linting?

EDIT: Maybe I should remove details from the doc string and point at the documentation instead.

[bbatsov]

You can't have inlined code in the docstrings, just references to params and symbols. I guess you can either reword this or add a link to the manual.

[simon-katz]

I've re-worded the doc string. Ready for re-review.

[simon-katz]

Whoops — I've reworded things incorrectly. Let me fix that…

EDIT …fixed — I've pointed at the documentation.

[bbatsov]

Thanks!

[simon-katz]

@bbatsov Thanks for your help.