Add support to filter out CIDER's internal namespaces and vars #1724
Conversation
| @@ -204,6 +204,18 @@ Sub-match 1 must be the project path.") | |||
| (defvar cider-host-history nil | |||
| "Completion history for connection hosts.") | |||
|
|
|||
| (defcustom cider-filter-regexps '("cider.nrepl" "refactor-nrepl") | |||
There was a problem hiding this comment.
As those are regexps, I guess they should start with ^ (beginning of string). I'd also filter nREPL's own namespaces.
There was a problem hiding this comment.
Not sure if we can't think of a better name for the variable. Right now it's not really clear what this is filtering without reading the docstring.
There was a problem hiding this comment.
-filtered-namespaces-regexps?
There was a problem hiding this comment.
I'm not sure if this was applied just to the ns of something of to the entire fully qualified name.
|
Why didn't you place this defcustom in |
|
You'll also have to rebase. |
| @@ -29,6 +29,7 @@ | |||
| * Use `cider-apropos-select` instead of `cider-apropos` in `cider-apropos-documentation-select`. | |||
| * [#1561](https://github.com/clojure-emacs/cider/issues/1561): Use an appropriate font-lock-face for variables, macros and functions in | |||
| the ns-browser. | |||
| * [#1564](https://github.com/clojure-emacs/cider/issues/1564): CIDER's internal namespaces and vars are filtered from the ns-browser and apropos functions. | |||
There was a problem hiding this comment.
Guess this should be in new features.
Hide all nREPL middleware details from `cider-browse-ns*` and `cider-apropos*` commands by customizing the variable `cider-filter-regexps`. It should be a list of regexps matching the pattern of namespaces you want to filter out.
|
I've made all the changes and rebased against the latest master. The |
|
👍 |
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
make test)M-x checkdocwarningsThanks!
For #1564