Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider's namespaces and vars should be filtered pretty much everywhere #1564

Closed
bbatsov opened this issue Feb 14, 2016 · 3 comments
Closed

cider's namespaces and vars should be filtered pretty much everywhere #1564

bbatsov opened this issue Feb 14, 2016 · 3 comments

Comments

@bbatsov
Copy link
Member

bbatsov commented Feb 14, 2016

In a lot of places (e.g. apropos, the ns browser, etc) the users can see cider's namespaces and vars. We should filter those out (although we also need a way to not filter them while hacking on cider itself).

@Malabarba Malabarba added this to the The UX release (v0.12?) milestone Feb 14, 2016
@Malabarba Malabarba modified the milestones: The UX release (v0.12?), v0.13.0 Apr 15, 2016
@ckoparkar
Copy link
Contributor

ckoparkar commented Apr 25, 2016

I'd like to give this a try. Two approaches I can think of:

  • Put a filtering fn in cider somewhere, and a custom var which would contain the filtering prefixes.
    Then, all functions, cider-sync-request:*, would filter out the configured prefixes.
  • Or, we could add another param to middleware requests, something like filter?, which would pass the prefixes and then the middleware would take care of this.

Thoughts ? I like the second one better.

@bbatsov @Malabarba

@expez
Copy link
Member

expez commented Apr 25, 2016

We already do this in the middleware for the dependencies we've munged with mranderson.

@ckoparkar
Copy link
Contributor

ckoparkar commented Apr 25, 2016

@expez Oh. Are you referring to the inlined-dependency fn? Guess we'll have to add support to optionally filter out cider.nrepl and refactor-nrepl in a similar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants