Add every favicon permutation under the sun #361
Conversation
|
I left the original favicon.ico, but could update that too if you like. |
| [:meta {:name "apple-mobile-web-app-title" :content "Clojars"}] | ||
| [:meta {:name "application-name" :content "Clojars"}] | ||
| [:meta {:name "msapplication-TileColor" "#da532c"}] | ||
| [:meta {:name "msapplication-TileImage" "/mstile-144x144.png?v=47K2kprJd7"}] |
There was a problem hiding this comment.
Lines 115 is missing an :href key, and 118 and 119 are missing a :content key. Would you mind fixing those?
|
I had no idea favicons had become so complicated, thanks for this. If you'll fix the meta issues, I'll pull this and see how the full icon looks for the common cases. |
|
I've fixed this, sorry about that. |
The query parameter on images is to bust browser caches Generated by http://realfavicongenerator.net Fixes #333
|
This looks good! I don't have a larger logo, but @devn may be able to provide one. I'm comfortable with the way they look now, but if you want to wait and see if we can get a higher-res image, we can. As for needing a favicon.ico, I defer to your judgment. |
|
Unfortunately I don't have access to a higher resolution image. Sorry :\ |
|
@devn - no worries, thanks for letting us know. |
|
I think it would be better to keep the current favicon.ico, it will look better than scaling a large image to a very small one. |
|
Sounds good to me - I'll merge this, but may wait to see if we can get a few other fixes in before I release. |
Add every favicon permutation under the sun
Add every favicon permutation under the sun
I used http://realfavicongenerator.net to generate every possible favicon that you could want. I used the 170x170
clojars-logo-big.png. A higher resolution image would be nicer, but I think it looks good like this. Happy to rerun it again if you've got a larger source image. The query parameter on images is to bust browser caches.The realfavicongenerator FAQ explains all about the different files. Let me know if you've got any questions though.
Fixes #333