Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update favicon #333

Closed
dubiousdavid opened this issue May 1, 2015 · 2 comments
Closed

Please update favicon #333

dubiousdavid opened this issue May 1, 2015 · 2 comments
Labels
ready-for-work size:small

Comments

@dubiousdavid
Copy link

Please update the favicon on clojars.org to correspond with the logo here: https://clojars.org/images/clojars-logo-small.png.
@tobias
Copy link
Member

tobias commented May 1, 2015

This should be a simple change to https://github.com/ato/clojars-web/tree/master/src/clojars/web/common.clj#L40. Thanks for noticing it was missing.

tobias added a commit that referenced this issue Jun 1, 2015
@tobias
Add better favicon [#333]
9313bf8
@tobias
Copy link
Member

tobias commented Jun 1, 2015

I used a square crop of the logo since the icon needs to be square, and the full image gets squashed to fit a square. I'm happy to put something better there if someone were to provide it.

@danielcompton danielcompton mentioned this issue Jul 7, 2015
Merged
swr1bm86 pushed a commit to swr1bm86/clojars-web that referenced this issue Oct 3, 2015
@tobias
Add better favicon [clojars#333]
5410bcf
swr1bm86 pushed a commit to swr1bm86/clojars-web that referenced this issue Oct 3, 2015
@danielcompton
Add every favicon permutation under the sun
cd7dcf3 
The query parameter on images is to bust browser caches
Generated by http://realfavicongenerator.net
Fixes clojars#333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready-for-work size:small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobias @dubiousdavid