Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ruby deprecation warning #69

Closed
wants to merge 5 commits into from
Closed

Enable ruby deprecation warning #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c68f55
enable warning on app, and rsepc
wendy-clio Jun 5, 2024
4487727
add test scenario to make sure deprecated warning is triggered
wendy-clio Jun 5, 2024
8e1ac9c
remove warning and test; update github workflow
wendy-clio Jun 5, 2024
a1f4026
enable warning on app, and rsepc
wendy-clio Jun 5, 2024
4c505d9
add test scenario to make sure deprecated warning is triggered
wendy-clio Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
--color
--warning
--require spec_helper
1 change: 1 addition & 0 deletions lib/jit_preloader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
require 'jit_preloader/preloader'

module JitPreloader
Warning[:deprecated] = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will set Warning[:deprecated] true when this file gets parsed. Is that what we want? Shouldn't we be isolating this to the specs for this gem, putting that line in the spec_helper.rb file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this PR is to enable deprecated warnings with CI run so they can be fixed. However, the PR does not intend to be merged, so I think it matters little where I put it as long as it enables the warnings properly.

def self.globally_enabled=(value)
@enabled = value
end
Expand Down