Enable ruby deprecation warning #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendy-clio
force-pushed
the
enable_deprecated_warning
branch
3 times, most recently
from
166cf58
to
a668f49
Compare
wendy-clio
force-pushed
the
enable_deprecated_warning
branch
from
a668f49
to
4c505d9
Compare
Merged
apalmblad
reviewed
Jun 10, 2024
| @@ -22,6 +22,7 @@ | |||
| require 'jit_preloader/preloader' | |||
|
|
|||
| module JitPreloader | |||
| Warning[:deprecated] = true | |||
There was a problem hiding this comment.
This looks like it will set Warning[:deprecated] true when this file gets parsed. Is that what we want? Shouldn't we be isolating this to the specs for this gem, putting that line in the spec_helper.rb file?
There was a problem hiding this comment.
The point of this PR is to enable deprecated warnings with CI run so they can be fixed. However, the PR does not intend to be merged, so I think it matters little where I put it as long as it enables the warnings properly.
|
Just double checking if we still need this |
No, the version is already updated, I will close this draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable ruby deprecation warning to find any codes that need refactoring before upgrading to ruby 3.
This PR is only for triggering the ci and inspecting the tests log for deprecation warnings, not for merge.