-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade to vite 5.x + upgrade related packages #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her related libraries (pug, sass, postcss)
…check warning ignore list
… for svelte files using ts)
…deprecation warning
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #518
This upgrades all uses of vite to the latest 5.x version. As part of this, I had to upgrade a number of related packages since one thing leads to another (vite plugins that use svelte assume a newer version of svelte, svelte/eslint packages assume newer versions of dependencies, and so on).
The only thing to note is that I updated the
peerDependencies
specifier for theplugin-vite
package to allow projects to use any 3.x, 4.x, or 5.x version of vite since there were no visible incompatibilities in 5.x in terms of howplugin-vite
interacts with a vite config file.In summary, this change should have no ramifications on consumers of
@sdeverywhere
packages.