fix: make sde log wait for DAT file to be fully written and improve error handling
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd more error handling" This reverts commit deba185.
|
That all looks reasonable. I was not able to test the intermittent write failure, since I don't have a failing test. Generating and catching an exception on the other errors instead of just printing an error message is the right way to do it. |
|
Thanks, Todd. I meant to include links to the latest build logs. Before this fix, nearly every GH Actions build would include one or more tests with the error message listed in the issue description. After this fix, the error no longer appears: (I re-ran the build a few times to verify.) |
ToddFincannon
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
See issue for more details. The primary fix (wait for the write buffer to be flushed) is in
sde-log.js, and the rest improves the error handling forsde testso that it makes the build fail fast.