You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the first issue (sde test fails to output DAT file intermittently), I found an issue in sde-log.js in the writeDat function. It was calling stream.end then immediately resolving the promise. The problem is that the OS may not have flushed the write buffer to the output file yet, which is why we'd intermittently get an error message saying that the output DAT file is not found. That code needs to be changed to wait for the finish event, which is called only after the buffer is flushed.
For the second issue, we need to improve the error handling in sde-test and sde-compare so that it exits with a non-zero exit code if some step fails.
I just noticed that sometimes one or more tests will fail (sporadically) when running on GitHub Actions, for example:
https://github.com/climateinteractive/SDEverywhere/runs/3677720774?check_suite_focus=true#step:4:65
Example error message:
This has apparently been happening for a while now. I went back through the build logs and found examples of this going back as far as this build on July 24:
https://github.com/climateinteractive/SDEverywhere/actions/runs/1063070071
I didn't find examples of the issue in builds before that one, but it doesn't necessarily mean that change is to blame (and it probably isn't).
There are two issues at play here:
sde test
encounters an error; the build should fail in this case.The text was updated successfully, but these errors were encountered: