Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CSV data for numeric cell values #284

Closed
ToddFincannonEI opened this issue Dec 8, 2022 · 0 comments · Fixed by #288
Closed

Check CSV data for numeric cell values #284

ToddFincannonEI opened this issue Dec 8, 2022 · 0 comments · Fixed by #288
Assignees
@ToddFincannonEI
Labels
bug pkg:compile

Comments

@ToddFincannonEI
Copy link
Collaborator

SDEverywhere assumes that all cells have numeric values. The equation generator for GET DIRECT DATA and GET DIRECT CONSTANTS throws an unhandled exception when the value is text. We discovered this when bad data crept into some CSV files. Vensim silently converts text cells in CSV files to zeroes without issuing a warning, so it was only apparent when converting the model with SDEverywhere. This needs to be handled better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ToddFincannonEI ToddFincannonEI

Labels
bug pkg:compile
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check for valid numbers when reading a CSV file climateinteractive/SDEverywhere
2 participants
@chrispcampbell @ToddFincannonEI