Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider warning/error handling like GCC's -Werror #290

Open
chrispcampbell opened this issue Dec 8, 2022 · 0 comments
Open

Consider warning/error handling like GCC's -Werror #290

chrispcampbell opened this issue Dec 8, 2022 · 0 comments

Comments

@chrispcampbell
Copy link
Contributor

In #284 we added better error reporting for cases where a CSV cell contains a non-numeric value, but decided to leave it as a soft error. There are cases where one might prefer soft error / warning vs hard error / fail-fast. In some cases you want them treated like warnings (and continue processing) so that you can get a sense of how many issues there are. For production builds, you probably want them treated like hard errors (and fail fast).

We have a couple other issues (e.g., #158) where SDE doesn't fail fast though it probably should.

I think we could cover both use cases by adding a flag that works like GCC's -Werror, i.e., treat things as a warning by default (just log the error), but allow for treating them as a hard error if the flag is passed on the command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant