You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using plugin-check to open a report in dev mode (in a project that uses pnpm but doesn't have the moment package available via hoisting or by other means), Vite will report an error:
The following dependencies are imported but could not be resolved:
moment (imported by /.../foo-check-bundle/dist/foo-check-bundle.mjs)
Are they installed?
The issue is that chart.js 2.9.x treats moment as an optional dependency (uses a fail-able require at runtime), so they recommend excluding it if it's not needed.
We can change vite-config-for-report.ts and add moment to the exclude list similar to what we do for threads.js and tiny-worker.
The text was updated successfully, but these errors were encountered:
When using
plugin-check
to open a report in dev mode (in a project that uses pnpm but doesn't have themoment
package available via hoisting or by other means), Vite will report an error:The issue is that
chart.js
2.9.x treatsmoment
as an optional dependency (uses a fail-ablerequire
at runtime), so they recommend excluding it if it's not needed.We can change
vite-config-for-report.ts
and addmoment
to the exclude list similar to what we do for threads.js and tiny-worker.The text was updated successfully, but these errors were encountered: