Skip to content

Commit

Permalink
fix: exclude moment dependency in plugin-check report config (#226)
Browse files Browse the repository at this point in the history
Fixes #225
  • Loading branch information
chrispcampbell authored Aug 9, 2022
1 parent 0ae4bd1 commit 3e9da1a
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions packages/plugin-check/src/vite-config-for-report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,17 @@ export function createViteConfigForReport(
'chart.js'
],

// XXX: The threads.js implementation references `tiny-worker` as an optional
// dependency, but it doesn't get used at runtime, so we can just exclude it
// so that Vite doesn't complain in dev mode
exclude: ['tiny-worker']
exclude: [
// XXX: The threads.js implementation references `tiny-worker` as an optional
// dependency, but it doesn't get used at runtime, so we can just exclude it
// so that Vite doesn't complain in dev mode
'tiny-worker',

// XXX: Similarly, chart.js treats `moment` as an optional dependency, but we
// don't use it at runtime; we need to exclude it here, otherwise Vite will
// complain about missing dependencies in dev mode
'moment'
]
},

// Configure path aliases
Expand Down

0 comments on commit 3e9da1a

Please sign in to comment.