Jazzy 2.0 RC #92
Draft
Jazzy 2.0 RC #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROS 2 Socket CAN Bridges
…as not (currently) supported (#86) * Add initial support for flagging unsupported accessories (e.g. Kinova arms, whose binary drivers don't exist in Jazzy yet) * classmethod -> staticmethod * Use the ROS_DISTRO variable from clearpath_generator_common instead of hard-coding the distro * Start fixing up python linter errors, code formatting, replace % strings with f'' strings. * Finish first-pass replacing " -> ' * Fix remaining linter errors. Some tests are still failing, but the major code tidying-up should be done now * Fix type -> _type * Update CI for Jazy * Update Python package workflow for Jazzy * Remove dependency on clearpath_generator_common; doing so creates a circular dependency. Instead use the system level envar * Add the ability to flag whole platforms as deprecated and/or unsupported * Docs * Fix imperative tone, missing periods in docstrings, missing newline at end of file * Mark everything besides Jackal and Husky as presently unsupported * Fix up sample yaml formatting. Remove unmatched quotation marks, restructure to avoid `foo.bar.spam: eggs` notation * Fix quotation marks for the sample serial number
* Add the initial AxisCamera class with all ROS parameters defined in axis_camera's launch files & nodes * Remove duplicate argument * Add the AxisCamera class to the sensors generator * Add the serial to the axis camera's template * Add serial to the template keys too * Add serial getter/setter. Use empty string as default serial * Refactoring, set the property to the value for the template * frame_width -> width, frame_height -> height * Rename setter * Make the scales & offsets floats by default * Add the TF prefix parameter * Add the camera_info_url parameter * camera_num -> camera * Note that the serial isn't used, fix the name of the PTZ teleop parameter * Add the remaining camera topics to the Topics object * image_raw -> image * Add axis_camera sample * Linting fixes * End docstring with `.`
…as not (currently) supported (#86) * Add initial support for flagging unsupported accessories (e.g. Kinova arms, whose binary drivers don't exist in Jazzy yet) * classmethod -> staticmethod * Use the ROS_DISTRO variable from clearpath_generator_common instead of hard-coding the distro * Start fixing up python linter errors, code formatting, replace % strings with f'' strings. * Finish first-pass replacing " -> ' * Fix remaining linter errors. Some tests are still failing, but the major code tidying-up should be done now * Fix type -> _type * Update CI for Jazy * Update Python package workflow for Jazzy * Remove dependency on clearpath_generator_common; doing so creates a circular dependency. Instead use the system level envar * Add the ability to flag whole platforms as deprecated and/or unsupported * Docs * Fix imperative tone, missing periods in docstrings, missing newline at end of file * Mark everything besides Jackal and Husky as presently unsupported * Fix up sample yaml formatting. Remove unmatched quotation marks, restructure to avoid `foo.bar.spam: eggs` notation * Fix quotation marks for the sample serial number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.