docs: Annotate with required features #2842
Conversation
|
As I said in the PR, rust-lang/rust#89596 auto does it and we don't need these attributes. All we need is |
| @@ -105,6 +105,7 @@ unicode = ["textwrap/unicode-width", "unicase"] # Support for unicode character | |||
| # Optional | |||
| wrap_help = ["terminal_size", "textwrap/terminal_size"] | |||
| yaml = ["yaml-rust"] | |||
| nightly = [] | |||
There was a problem hiding this comment.
Please rename this feature to doc which is more meaningful and which is what we used to do before to use some nightly doc features.
There was a problem hiding this comment.
imo the name should make clear it requires the nightly toolchain. I also don't see a reason for us to restrict this flag to jsut docs.
There was a problem hiding this comment.
How about nightly-doc? We want to differentiate between the features for docs.rs and actual features (if we have any).
That was merged two days ago, so it depends on what our release timelines are. |
Just tested, already working. |
You are right, docs.rs uses nightly which we were also taking advantage of in this PR. |
This is requiring a nightly feature. iirc docs.rs uses nightly, so this should be work so long as it doesn't change too much on us.
The tracking issue is rust-lang/rust#43781