Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gate App::replace #2837

Merged
merged 1 commit into from
Oct 9, 2021
Merged

fix: Gate App::replace #2837

merged 1 commit into from
Oct 9, 2021

Conversation

epage
Copy link
Member

@epage epage commented Oct 9, 2021

We are concerned about the level of polish of this feature and are
unsure enough about its future, we've decided to gate it to unblock the
v3 release.

We are concerned about the level of polish of this feature and are
unsure enough about its future, we've decided to gate it to unblock the
v3 release.
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

I guess, we don't need to gate any parsing logic or the struct members since the replacers are empty. Would be nice if we can but that's too many gates I guess.

@bors
Copy link
Contributor

bors bot commented Oct 9, 2021

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Contributor

bors bot commented Oct 9, 2021

Build succeeded:

@bors bors bot merged commit e8ec11e into clap-rs:master Oct 9, 2021
@epage epage deleted the replace branch October 9, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants