#7997: Migrated Input and Delete features to beforeinput #8176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges" in the same event.
…d links because beforeinput does not supply it. Used the "direction" property instead.
…ations to separate helpers. Code refactoring.
…h. Code refactoring.
…t being the default source of typing.
niegowski
reviewed
Oct 1, 2020
packages/ckeditor5-restricted-editing/src/restrictededitingmodeediting.js
Show resolved
Hide resolved
Co-authored-by: Kuba Niegowski <[email protected]>
niegowski
reviewed
Oct 5, 2020
packages/ckeditor5-typing/src/utils/delete/injectbeforeinputdeletehandling.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-typing/src/utils/delete/injectbeforeinputdeletehandling.js
Show resolved
Hide resolved
…ead of "character".
niegowski
reviewed
Oct 6, 2020
packages/ckeditor5-typing/src/utils/delete/injectbeforeinputdeletehandling.js
Outdated
Show resolved
Hide resolved
…letehandling.js Co-authored-by: Kuba Niegowski <[email protected]>
…nputDeleteHandling().
…foreInputDeleteHandling().
This was referenced Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Migrated
Input,Delete, andEnterfeatures to thebeforeinputevent. Closes #7997. Closes #7998. Closes #7999.BREAKING CHANGE (engine): The
MutationObservermay no longer be loaded by the editing view. In web browsers that support DOM Input Events, its responsibilities have been taken over byInputObserver.BREAKING CHANGE (engine): The
mutationsevent is no longer fired by the view document in web browsers that support DOM Input Events. To react to low-level changes in the document, use thebeforeinputevent instead, or better yet, take advantage ofdeleteandinsertTextevents.BREAKING CHANGE (typing): The InputCommand has been deprecated. Use the
InsertTextCommandinstead (editor.execute( 'insertText', options )).BREAKING CHANGE (typing): The
@ckeditor/ckeditor5-typing/src/utils/injectunsafekeystrokeshandlingmodule containing typing helpers (e.g.isNonTypingKeystroke()) is now available under@ckeditor/ckeditor5-typing/src/utils/input/utils. Please update import paths in your projects to avoid import errors.