Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and stabilize composition (IME) using beforeInput on Android #8011

Closed
oleq opened this issue Sep 3, 2020 · 3 comments
Closed

Test and stabilize composition (IME) using beforeInput on Android #8011

oleq opened this issue Sep 3, 2020 · 3 comments
Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Sep 3, 2020

Provide a description of the task

A twin to #8008 except that it's Android that must be tested. For starters, I'd go with the default Android web browser (that is Chrome most of the time, I guess) and few popular keyboards (because it's the keyboard that matters when it comes to IME).
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:typing domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:mobile This issues reports a problem related to a mobile environment. and removed domain:dx This issue reports a developer experience problem or possible improvement. labels Sep 3, 2020
@Reinmar Reinmar mentioned this issue Sep 3, 2020
Closed
13 tasks
@oleq oleq added this to the iteration 36 milestone Sep 3, 2020
@oleq oleq added the squad:dx label Sep 3, 2020
@Reinmar Reinmar modified the milestones: iteration 36, iteration 37 Sep 28, 2020
@oleq
Copy link
Member Author

oleq commented Sep 29, 2020

I briefly checked out the status of things on Android 10 and it turned out it uses composition a lot, also for basic typing. While normal insertText works, insertCompositionText is used whenever the word is underlined (suggesting), which is like 80% of the time, also using English keyboard (it's not IME-related).

@oleq oleq mentioned this issue Oct 6, 2020
Merged
@oleq
Copy link
Member Author

oleq commented Oct 6, 2020

TODO: #8176 (comment)

@Reinmar Reinmar modified the milestones: iteration 37, nice-to-have Oct 14, 2020
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Sep 9, 2021
@Reinmar Reinmar removed the squad:dx label Sep 27, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@Reinmar
Copy link
Member

Reinmar commented Jul 19, 2022

Closed together with #7462. We're reorganizing the work in #11438.

@Reinmar Reinmar closed this as completed Jul 19, 2022
@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Reinmar @oleq @pomek