Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and stabilize composition (IME) using beforeInput on desktop browsers (Mac) #8008

Closed
oleq opened this issue Sep 3, 2020 · 1 comment
Closed

Test and stabilize composition (IME) using beforeInput on desktop browsers (Mac) #8008

oleq opened this issue Sep 3, 2020 · 1 comment
Labels
browser:chrome browser:edge browser:safari domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Sep 3, 2020 •
edited
Loading

Provide a description of the task

On a F2F call with @niegowski we discovered that Safari on Mac uses deleteByComposition to recompose the typed content. It was a surprise because it seems Chrome does not do that so there are some differences within the same operating system when it comes to IME.

All Mac-compatible browsers must be tested thoroughly to make sure composition is stable and all use-cases (like recomposition) are covered.

Some extra things to verify:

  • does the spell check work (accepting changes)?
  • does the autocorrection work (spell checker changing words as you type)?
  • do accented letters work (they are not a composition on Mac)?
@oleq oleq added the type:task This issue reports a chore (non-production change) and other types of "todos". label Sep 3, 2020
This was referenced Sep 3, 2020
Closed
Closed
Closed
Closed
@oleq oleq added domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:typing domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). browser:chrome browser:firefox browser:safari browser:edge and removed domain:dx This issue reports a developer experience problem or possible improvement. labels Sep 3, 2020
@Reinmar Reinmar mentioned this issue Sep 3, 2020
Closed
13 tasks
@oleq oleq added this to the iteration 36 milestone Sep 3, 2020
@Reinmar Reinmar modified the milestones: iteration 36, iteration 37 Sep 28, 2020
@Reinmar Reinmar modified the milestones: iteration 37, nice-to-have Oct 14, 2020
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Sep 9, 2021
@Reinmar Reinmar removed the squad:dx label Sep 27, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@Reinmar
Copy link
Member

Reinmar commented Jul 19, 2022

Closed together with #7462. We're reorganizing the work in #11438.

@Reinmar Reinmar closed this as completed Jul 19, 2022
@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser:chrome browser:edge browser:safari domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Reinmar @oleq @pomek