Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other (link): Exported link and unlink icons from ckeditor5-link package #17306

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Other (link): Exported link and unlink icons from ckeditor5-link package #17306

merged 1 commit into from
Oct 23, 2024

Conversation

Mgsy
Copy link
Member

@Mgsy Mgsy commented Oct 23, 2024 •
edited
Loading

Suggested merge commit message (convention)

Other (link): Exported link and unlink icons from ckeditor5-link package.

Closes #17304

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

niegowski
niegowski approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only export of SVGs from a package other than the core package, but we expect all SVG exports to change soon.

@niegowski niegowski merged commit 9decc1e into master Oct 23, 2024
10 checks passed
@niegowski niegowski deleted the ck/17304 branch October 23, 2024 14:14
@brianjhanson brianjhanson mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niegowski niegowski niegowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link and unlink icons are missing in the icons object
2 participants
@Mgsy @niegowski