Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link and unlink icons are missing in the icons object #17304

Closed
Mgsy opened this issue Oct 23, 2024 · 2 comments · Fixed by #17306
Closed

Link and unlink icons are missing in the icons object #17304

Mgsy opened this issue Oct 23, 2024 · 2 comments · Fixed by #17306
Labels
support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 79 (v43...

Comments

@Mgsy
Copy link
Member

Mgsy commented Oct 23, 2024

📝 Provide detailed reproduction steps (if any)

Our icons object is missing the link and unlink icons- https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-core/src/index.ts#L123.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Mgsy Mgsy added the type:improvement This issue reports a possible enhancement of an existing feature. label Oct 23, 2024
@aldonace-wu aldonace-wu added the support:2 An issue reported by a commercially licensed client. label Oct 23, 2024
@Mgsy Mgsy mentioned this issue Oct 23, 2024
Merged
niegowski added a commit that referenced this issue Oct 23, 2024
@niegowski
Merge pull request #17306 from ckeditor/ck/17304
9decc1e 
Other (link): Exported link and unlink icons from ckeditor5-link package. Closes #17304
@CKEditorBot CKEditorBot added this to the iteration 79 milestone Oct 23, 2024
@CKEditorBot CKEditorBot mentioned this issue Oct 24, 2024
Open
@NesTeRDGIT NesTeRDGIT mentioned this issue Oct 30, 2024
Closed
@brianjhanson
Copy link

I'm seeing the same issue in 44.0.0. It looks like the exports were added in #17306 but then reverted in #17363.

I seem to be able to access the SVG via import linkIcon from '@ckeditor/ckeditor5-link/theme/icons/link.svg'; but admittedly that seems like a bad idea.

Is there some other workaround to be able to use icons.link?

@Witoso
Copy link
Member

Witoso commented Dec 6, 2024 •
edited
Loading

Copying the files to your project. The change caused issues in some setups, so we needed to revert it. We will clean up the icons situation early next year probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 79 (v43.3.0)
Development

Successfully merging a pull request may close this issue.

Other (link): Exported link and unlink icons from ckeditor5-link package ckeditor/ckeditor5
5 participants
@brianjhanson @Witoso @Mgsy @CKEditorBot @aldonace-wu