-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to the link form #15633
Conversation
Update guide mention needed in this (how to restore previous behavior). |
…tion-to-the-link-form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved ✅
Just a few typos to fix.
I like that you added InputUrlView
class 👍
We must not forget about #15633 (comment). Do we have a follow-up issue or have we mentioned it somewhere?
The URL input itself looks great, I even wondered if it could be decided dynamically which one is used (when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only spotted some minor mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more typos to be fixed.
Generally looks good 👍 but I've found one case where the button is active even though the input text is empty. But this doesn't add an empty link to the editor because the link text is empty. IMO it's worth fixing so that the UI is consistent.
Screen.Recording.2024-01-08.at.11.41.27.mov
Co-authored-by: Marta Motyczynska <[email protected]>
…ike `value` and `isEmpty`
…tion-to-the-link-form' into ck/12501-add-validation-to-the-link-form
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it looks good to me!
Suggested merge commit message (convention)
MINOR BREAKING CHANGE (link): Add validation to the URL field to disallow empty URL by default. Closes #12501.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.