-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty value is getting added as a link to a text. #12501
Comments
It would be great, if we could get any update on this. |
CKE5 needs to preserve empty links as they unfortunately may exist in a content. As for the UI, there's no validation indeed. How do you think it should work? And why do you think there should be validation? |
so, earlier in CKe4 the URL was a mandatory field in the popup of link so when user doesn't enter it'll throw an error. So the customers were expecting the behaviour to be same as of CKe4. |
This is a big regression for us going from CKEditor 4 to CKEditor 5. We allow content editors to put button styles on We're not asking for empty URL's to be banned everywhere. It'd just be nice to have a mechanism/option to not allow empty URL's that we could configure. |
Preserving empty links in the editor isn't a problem, it's being allowed to create them in the first place. We don't want to strip them if they're in the editor, and meant to be there. We just don't want our users to be allowed to create them without manually editing the source code. Just a toggleable option to prevent blank input in the URL field would suffice. |
Thanks @joegl for feedback! I will bring it for discussions internally on our side. |
Internally, we decided on the future scope:
The editor will still preserve empty links when loaded. |
@Witoso That sounds wonderful! Thanks for your considerations and responding to this. When would you anticipate this change being completed and release? |
No ETA yet, this will enter our support queue as an improvement. |
MINOR BREAKING CHANGE (link): Add validation to the URL field to disallow empty URL by default. Closes #12501.
📝 Provide detailed reproduction steps (if any)
✔️ Expected result
Empty value shouldn't be getting added as a link.
❌ Actual result
Empty value is getting added as a link to a text.
📃 Is this the expected behavior or is there anyway we could have validation?
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: