Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MultiRootEditor#registerRootAttribute() #15287

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Added MultiRootEditor#registerRootAttribute() #15287

merged 3 commits into from
Nov 6, 2023

Conversation

scofalik
Copy link
Contributor

Suggested merge commit message (convention)

Feature (editor-multi-root): Added MultiRootEditor#registerRootAttribute(). All roots attributes used by features should now be registered. Roots attributes passed in editor config are now automatically registered. Closes #15246.

MINOR BREAKING CHANGE (editor-multi-root): If you use a custom plugin that uses roots attributes, it is recommended to use newly added MultiRootEditor#registerRootAttribute() to register the custom root attribute.

…bute()`. All roots attributes used by features should now be registered. Roots attributes passed in editor config are now automatically registered.

MINOR BREAKING CHANGE (editor-multi-root): If you use a custom plugin that uses roots attributes, it is recommended to use newly added `MultiRootEditor#registerRootAttribute()` to register the custom root attribute.
Copy link
Contributor

@DawidKossowski DawidKossowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scofalik scofalik merged commit 5404c1a into master Nov 6, 2023
@scofalik scofalik deleted the ck/15246 branch November 6, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-root editor loses initial attributes after pasting content
3 participants