Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-root editor loses initial attributes after pasting content #15246

Closed
DawidKossowski opened this issue Oct 25, 2023 · 0 comments · Fixed by #15287
Closed

Multi-root editor loses initial attributes after pasting content #15246

DawidKossowski opened this issue Oct 25, 2023 · 0 comments · Fixed by #15287
Labels
package:editor-multi-root squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 68 (v40...

Comments

@DawidKossowski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Create an multi-root editor with at least 2 roots that contain attributes.
  2. Copy at least 2 lines from the first root.
  3. Paste the content inside the second root.

✔️ Expected result

The attributes of the second root do not change.

❌ Actual result

The attributes of the second root are empty.

Nagranie.z.ekranu.2023-10-25.o.12.57.19.mov

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@DawidKossowski DawidKossowski added type:bug This issue reports a buggy (incorrect) behavior. squad:collaboration Issue to be handled by the Collaboration team. package:editor-multi-root labels Oct 25, 2023
@DawidKossowski DawidKossowski changed the title Multi-root editor loses initial attributes after copy paste content Multi-root editor loses initial attributes after pasting content Oct 25, 2023
@oleq oleq self-assigned this Oct 26, 2023
@DawidKossowski DawidKossowski mentioned this issue Oct 30, 2023
Closed
@scofalik scofalik mentioned this issue Oct 31, 2023
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 31, 2023
scofalik added a commit that referenced this issue Nov 6, 2023
@scofalik
Merge pull request #15287 from ckeditor/ck/15246
5404c1a 
Feature (editor-multi-root): Added `MultiRootEditor#registerRootAttribute()`. All roots attributes used by features should now be registered. Roots attributes passed in editor config are now automatically registered. Closes #15246.

MINOR BREAKING CHANGE (editor-multi-root): If you use a custom plugin that uses roots attributes, it is recommended to use newly added `MultiRootEditor#registerRootAttribute()` to register the custom root attribute.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 6, 2023
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Nov 6, 2023
@CKEditorBot CKEditorBot mentioned this issue Nov 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:editor-multi-root squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 68 (v40.1.0)
3 participants
@oleq @DawidKossowski @CKEditorBot