Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup colspans on single table row and single column. #6609

Closed
jodator opened this issue Apr 15, 2020 · 2 comments · Fixed by #7362
Closed

Cleanup colspans on single table row and single column. #6609

jodator opened this issue Apr 15, 2020 · 2 comments · Fixed by #7362
Assignees
@niegowski
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 33 (v20...

Comments

@jodator
Copy link
Contributor

jodator commented Apr 15, 2020

📝 Provide detailed reproduction steps (if any)

See: ckeditor/ckeditor5-table#303 (review).

+----+----+----+
| 00 | 01      |
+----+----+----+
| 10 | 11 | 12 |  <-- remove this row
+----+----+----+

✔️ Expected result

+----+----+
| 00 | 01 |
+----+----+

❌ Actual result:

+----+----+----+
| 00 | 01      |
+----+----+----+

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Apr 15, 2020
@niegowski
Copy link
Contributor

Another scenario with merging table cells:

Given:

+----+----+----+
| 00 | 01      |
+----+----+----+
| 10 | 11      |
+----+----+----+
| 20 | 21 | 22 |  <- merge cells 21 and 22
+----+----+----+

Expected result:

+----+----+
| 00 | 01 |
+----+----+
| 10 | 11 |
+----+----+
| 20 | 21 |
+----+----+

Actual result:

+----+----+----+
| 00 | 01      |
+----+----+----+
| 10 | 11      |
+----+----+----+
| 20 | 21      |
+----+----+----+

@jodator jodator added this to the iteration 32 milestone Apr 30, 2020
@Reinmar Reinmar modified the milestones: iteration 32, next, unknown May 6, 2020
@jodator jodator changed the title Cleanup colspans on single table row. Cleanup colspans on single table row and single column. May 20, 2020
This was referenced May 20, 2020
Merged
Closed
@jodator
Copy link
Contributor Author

jodator commented May 26, 2020

A similar case (but might be out of scope): #3192.

@jodator jodator assigned jodator and niegowski and unassigned jodator Jun 2, 2020
@jodator jodator modified the milestones: next, iteration 33 Jun 2, 2020
@niegowski niegowski mentioned this issue Jun 2, 2020
Merged
jodator added a commit that referenced this issue Jun 4, 2020
@jodator
Merge pull request #7362 from ckeditor/i/6609
11d69fc 
Fix (table): Removing empty rows will no longer produce an invalid table model in certain scenarios. Closes #6609.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

#6609: Removing empty columns (with no cells anchored) ckeditor/ckeditor5
3 participants
@Reinmar @jodator @niegowski